Add and remove moods. #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add and remove mood.
|
Initial testing worked great. Also 'multiple moods' is displayed in the app. One issue I noticed is that selecting the 'Off' mood does not work. Only 'unselecting' the enabled moods enables the Off mood. This can probably be resolved with an If statement and using 'changeTo' Off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a lot of open spaces where I combine multiple activated moods. Mood functionality using the API functions addMood and removeMood would improve my user experience a lot.
I am aware that this piece of code is not production worthy.
Ideally there should be a configuration setting introduced to enable and disable this behavior.