Allow Settings to be Overridden by Constants #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since both page-settings.php and wp-mail.php (class Postmark_Mail) need these settings a new file is created that will return an array of settings. The array of settings coming from the database is merged with the settings defined as constants, with constants taking priority.
In the WP Dashboard, show the user if settings have been overridden by constants, but don’t show them the actual constant values. This will somehwat obfuscate the API key from the user. (Think agencies that define constants for a client using the agencies sandboxed api key.)
|
@tflight Thanks for putting this PR together! I will review it this week. |
pgraham3
requested changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs review and documentation before merging.
This PR allows you to set constants in your
wp-config.phpfile which will override, but not overwrite, any settings stored in the database (WP options). API Key, Stream Name/ID, and Sender Address are supported. Example config:An example usage would be for a developer to use settings from a Postmark Sandbox stream in their development environment that would survive database merges. See #71. This also helps address #72.