Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAE-28451 Add subproceses to process instance #1617

Draft
wants to merge 30 commits into
base: develop
Choose a base branch
from
Draft

AAE-28451 Add subproceses to process instance #1617

wants to merge 30 commits into from

Conversation

shsahahyland
Copy link

Issue Link : AAE-28451

This PR is focusses around introducing a new subprocesses property with ProcessInstances

@shsahahyland shsahahyland added preview CI Triggers CI validation on dependabot PRs and removed CI Triggers CI validation on dependabot PRs labels Nov 22, 2024
graric
graric reviewed Nov 25, 2024
View reviewed changes
...rg/activiti/cloud/services/query/app/repository/CustomizedProcessInstanceRepositoryImpl.java
import org.springframework.data.jpa.repository.support.QuerydslRepositorySupport;
import org.springframework.data.support.PageableExecutionUtils;

public class CustomizedProcessInstanceRepositoryImpl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the mapSubprocesses methods, the process of loading subprocesses should be the same. Could you try using a single method for the find and set part of the subprocesses? Maybe by calling the mapSubprocesses(ProcessInstanceEntity processInstance) method from mapSubprocesses(Page processInstances, Pageable pageable)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I tried in the beginning but due to pageable it is difficult. Also mapSubprocess is used only for a single process instance . If we try calling it from mapSubprocesses(Page processInstances, Pageable pageable) it would mean a lot more database calls and I dont think we want that

graric
graric requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@graric graric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Could you please move the helpers(like ProcessInstanceControllerHelper) from package rest to a new package rest.helper?
Also please add the tests to cover the new changes.

@graric graric force-pushed the improvement/AAE-28451-process-instances-subprocess branch from 05f2145 to a263c64 Compare November 27, 2024 10:41
@shsahahyland shsahahyland force-pushed the improvement/AAE-28451-process-instances-subprocess branch 2 times, most recently from 130eea8 to 6746b50 Compare December 2, 2024 07:32
@shsahahyland shsahahyland force-pushed the improvement/AAE-28451-process-instances-subprocess branch from a4c68b6 to 2277a02 Compare December 2, 2024 16:14
graric
graric reviewed Dec 2, 2024
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graric graric graric requested changes

@andrea-ligios andrea-ligios Awaiting requested review from andrea-ligios

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shsahahyland @graric