OAuth TaskList - Yasmin #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe from boolean to datetime, and the other to change the name from completion to completed_at
…on that will render as a new view for the user
…a task as completed
…also changed the completed_at field in the form for easier entry
…nd also added the .env file to .gitignore
…entials available in the .env file
…ound setting up relationships between tasks and users as well as tinkering with authentication routes
… the schema) and added validations to the task model
…e login method to be required before every action
…henticated or not
… added the route and the action for login, also adjusted controller filter
… used a view helper method to format the date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that I met the requirements... I wasn't sure what changes to make to the task controller's new action since a new task is saved with the user's id in the create action, so the new action is still unchanged. I wanted to write controller tests, especially for the sessions controller, but I didn't have time to. It's just model tests for this project.