forked from AdaGold/api-muncher
-
Notifications
You must be signed in to change notification settings - Fork 47
Nicole Api Muncher #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nurlywhirly
wants to merge
46
commits into
Ada-C6:b/nmu/master
Choose a base branch
from
nurlywhirly:b/nmu/master
base: b/nmu/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cher into b/nmu/master
…ogether in the api wrapper
…le do that kind of thing.
…hing to compensate
…I think are memoization reasons
…o be fancy and split my stylesheets into different files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel I was kind of aimless in my controller tests. I attempted a lot of things and it wound up not working. (See comments)
I also feel like my routes are inherently off in some way. The way I always render :index instead of routing to there, I'm not sure it's kosher.
Overall, it functions but it doesn't feel right.