Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
praveek committed Nov 28, 2023
1 parent c8b595e commit d047ca5
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 25 deletions.
10 changes: 5 additions & 5 deletions gatsby-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -718,13 +718,13 @@ module.exports = {
title: "iOS",
path: "/resources/migration/ios",
pages: [{
title: "Migrate to 3.x SDKs",
path: "/resources/migration/ios/migrate-to-3x"
},
{
title: "Migrate to 4.x SDKs",
path: "/resources/migration/ios/migrate-to-4x"
}
},
{
title: "Migrate to 3.x SDKs",
path: "/resources/migration/ios/migrate-to-3x"
},
]
}
]
Expand Down
2 changes: 1 addition & 1 deletion src/pages/resources/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ Implementing push notification tracking and measurement with the SDK depends on

## Migrating to Android Mobile Core 2.x and compatible extensions

See the frequently asked questions for migration [here](../resources/migration/android/migrate-to-2x.md#frequently-asked-questions)
See the frequently asked questions for migration [here](../resources/migration/android/migrate-to-2x.md#frequently-asked-questions).

## Lifecycle

Expand Down
8 changes: 4 additions & 4 deletions src/pages/resources/migration/android/migrate-to-2x.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Tabs from './tabs/migrate-to-2x.md'

# Migrate to Adobe Experience Platform Mobile 2.x SDKs for Android
# Migrate to Adobe Experience Platform 2.x SDKs for Android

<InlineAlert variant="info" slots="text"/>

Expand Down Expand Up @@ -82,7 +82,7 @@ dependencies {
}
```

Save the `build.gradle` file and select `Sync Project with Gradle Files` in Android Studio to download the 2.x SDKs
Save the `build.gradle` file and select `Sync Project with Gradle Files` in Android Studio to download the 2.x SDKs.

#### Manual library import

Expand All @@ -106,7 +106,7 @@ Kotlin

## Update outdated API references

Some of the APIs available in previous major versions of the Mobile SDK for Android are now deprecated or removed. You can choose to replace the obsolete APIs in your code with the alternative APIs in the 2.x version, as described below:
Some of the APIs available in previous major versions of the Mobile SDK for Android are now deprecated or removed. You can choose to replace the obsolete APIs in your code with the alternative APIs in the 2.x version, as described below.

<InlineAlert variant="info" slots="text"/>

Expand Down Expand Up @@ -135,7 +135,7 @@ The `registerExtension` API for each extension is deprecated in the 2.x version

| Removed API | Alternative API |
| :------------- | :-------------- |
| CampaignClassic.registerDevice | The [CampaignClassic.registerDevice](../../../solution/adobe-campaign-classic/api-reference.md) API, no longer provides a callback method for registration status since a `false` value cannot be accurately used as a signal to retry requests. |
| CampaignClassic.registerDevice | The [CampaignClassic.registerDevice](../../../solution/adobe-campaign-classic/api-reference.md) API no longer provides a callback method for registration status since a `false` value cannot be accurately used as a signal to retry requests. |

### Places Service

Expand Down
8 changes: 4 additions & 4 deletions src/pages/resources/migration/android/tabs/migrate-to-2x.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

```java
public class MainApp extends Application {
private static final String ENVIRONMENT_FILE_ID = "ENVIRONMENT_FILE_ID";
private static final String ENVIRONMENT_FILE_ID = "<your_environment_file_id>";

@Override
public void onCreate() {
Expand All @@ -16,7 +16,7 @@ public class MainApp extends Application {
extensions.add(Assurance.EXTENSION);
extensions.add(Identity.EXTENSION);
MobileCore.registerExtensions(extensions, o -> {
Log.d(LOG_TAG, "AEP Mobile SDK is initialized");
Log.d(LOG_TAG, "Adobe Experience Platform Mobile SDK is initialized");
});
}
}
Expand All @@ -28,7 +28,7 @@ public class MainApp extends Application {

```kotlin
class MyApp : Application() {
val ENVIRONMENT_FILE_ID = "ENVIRONMENT_FILE_ID"
val ENVIRONMENT_FILE_ID = "<your_environment_file_id>"

override fun onCreate() {
super.onCreate()
Expand All @@ -42,7 +42,7 @@ class MyApp : Application() {
Assurance.EXTENSION
)
MobileCore.registerExtensions(extensions) {
Log.d(LOG_TAG, "AEP Mobile SDK is initialized")
Log.d(LOG_TAG, "Adobe Experience Platform Mobile SDK is initialized")
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions src/pages/resources/migration/ios/migrate-to-3x.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Tabs from './tabs/migrate-to-3x.md'

# Migrate to Adobe Experience Platform 3.x Mobile SDKs for iOS
# Migrate to Adobe Experience Platform 3.x SDKs for iOS

<InlineAlert variant="info" slots="text"/>

Expand Down Expand Up @@ -69,7 +69,7 @@ If you are manually importing SDK libraries, ensure you identify all currently u
If you are using CocoaPods to manage your Adobe Experience Platform Mobile SDK dependencies, the following example shows you how to switch ACP-prefix libraries to AEP-prefix libraries in your `Podfile`.

```ruby
# replace ACPCore with AEPCore/AEPLifecycle/AEPIdentity/AEPSignal
# replace ACPCore with AEPCore, AEPLifecycle, AEPIdentity and AEPSignal
# pod 'ACPCore'
pod 'AEPCore', '~> 3.0'
pod 'AEPLifecycle', '~> 3.0'
Expand Down Expand Up @@ -97,14 +97,14 @@ The following code snippets show the new and correct initialization code require

<TabsBlock orientation="horizontal" slots="heading, content" repeat="2"/>

Objective-C

<Tabs query="lang=obj-c"/>

Swift

<Tabs query="lang=swift"/>

Objective-C

<Tabs query="lang=obj-c"/>

## Update outdated API references

Finally, you'll need to scan through your current implementation and replace ACP-prefix API calls to the new Swift-based, AEP-prefix libraries. A quick find and replace should do the trick. Detailed API changes by extension may be found at the links below.
Expand Down
6 changes: 3 additions & 3 deletions src/pages/resources/migration/ios/migrate-to-4x.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Tabs from './tabs/migrate-to-4x.md'

# Migrate to Adobe Experience Platform Mobile 4.x SDKs for iOS
# Migrate to Adobe Experience Platform 4.x SDKs for iOS

<InlineAlert variant="info" slots="text"/>

Expand Down Expand Up @@ -84,10 +84,10 @@ The following APIs have been removed:

<TabsBlock orientation="horizontal" slots="heading, content" repeat="2"/>

AEP 3.x
iOS 3.x

<Tabs query="platform=ios&extension=edge&version=3"/>

AEP 4.x
iOS 4.x

<Tabs query="platform=ios&extension=edge&version=4"/>
4 changes: 2 additions & 2 deletions src/pages/resources/migration/ios/tabs/migrate-to-3x.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
const UIApplicationState appState = application.applicationState;
[AEPMobileCore setLogLevel: AEPLogLevelDebug];
[AEPMobileCore registerExtensions:@[AEPMobileSignal.class, AEPMobileLifecycle.class, AEPMobileUserProfile.class, AEPMobileIdentity.class, AEPMobileAssurance.class] completion:^{
[AEPMobileCore configureWithAppId: @""];
[AEPMobileCore configureWithAppId: @"<your_environment_file_id>"];
if (appState != UIApplicationStateBackground) {
// only start lifecycle if the application is not in the background
[AEPMobileCore lifecycleStart:@{@"contextDataKey": @"contextDataVal"}];
Expand All @@ -39,7 +39,7 @@ import AEPUserProfile
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
let appState = application.applicationState
MobileCore.registerExtensions([Signal.self, Lifecycle.self, UserProfile.self, Identity.self, Assurance.self], {
MobileCore.configureWith(appId: "")
MobileCore.configureWith(appId: "<your_environment_file_id>")
if appState != .background {
// only start lifecycle if the application is not in the background
MobileCore.lifecycleStart(additionalContextData: ["contextDataKey": "contextDataVal"])
Expand Down

0 comments on commit d047ca5

Please sign in to comment.