Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure AJO #437

Merged
merged 8 commits into from
Jan 19, 2024
Merged

Restructure AJO #437

merged 8 commits into from
Jan 19, 2024

Conversation

PravinPK
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PravinPK PravinPK requested a review from calebk1 October 24, 2023 23:08
PravinPK
PravinPK commented Oct 25, 2023
View reviewed changes
src/pages/edge/adobe-journey-optimizer/api-reference.md Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/api-reference.md
@@ -51,41 +37,19 @@ Android

<Tabs query="platform=android&api=register-extension"/>

## refreshInAppMessages
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

altered to use instead of tab for refreshInAppMessages API

src/pages/edge/adobe-journey-optimizer/in-app-message/tutorials/handle-clicks.md Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/index.md Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/index.md Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/push-notification/android/manual-display-and-tracking.md
@@ -0,0 +1,171 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newly created class. Should review

src/pages/edge/adobe-journey-optimizer/push-notification/index.md
@@ -0,0 +1,29 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newly created class. Should review

src/pages/edge/adobe-journey-optimizer/push-notification/ios/api-reference.md
@@ -0,0 +1,101 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newly created class. Should review

src/pages/edge/adobe-journey-optimizer/push-notification/ios/display-rich-notifications.md
@@ -0,0 +1,103 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newly created class. Should review

src/pages/edge/adobe-journey-optimizer/push-notification/tabs/push-payload.md
@@ -0,0 +1,94 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newly created class. Should review

calebk1
calebk1 reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments!

gatsby-config.js Outdated Show resolved Hide resolved
gatsby-config.js Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/in-app-message/validate-messages.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/in-app-message/validate-messages.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/in-app-message/validate-messages.md Outdated
Comment on lines 128 to 130
### Q: What do I do when one of the required extensions is missing?

**A:** Ensure that each required extension is linked to your project and registered by `MobileCore`. For more information, please read the [Mobile Core API reference](../../mobile-core/api-reference.md#registerextensions).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Q+A, I don't think we need to state it's a Q and A - we can just use the headers to let users know that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. It looks much cleaner. I think we should also enforce this in the EdgeIdentity's FAQ.

src/pages/edge/adobe-journey-optimizer/push-notification/android/manual-display-and-tracking.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/push-notification/android/manual-display-and-tracking.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/push-notification/android/manual-display-and-tracking.md Outdated
final String actionId) // actionId of the element which performed the custom action.
```

##### Sending push notification interaction feedback when application is opened without any custom action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going from an H2 to an H5 is a bit much. This should be an H3 instead. This goes for the latter ones too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bolded the text instead. Let me know if this works

src/pages/edge/adobe-journey-optimizer/push-notification/index.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/push-notification/tabs/push-payload.md Outdated Show resolved Hide resolved
calebk1
calebk1 reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor changes.

gatsby-config.js Outdated
path: "/edge/adobe-journey-optimizer/tutorials/messaging-delegate"
},
title: "Public classes and enums",
path: "/edge/adobe-journey-optimizer/public-classes-and-enum",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor - can we keep this as just "/public-classes" for the sake of not breaking links?

Not a huge deal if we do want to change the URLs, but it just means a few more redirects need to be created.

src/pages/edge/adobe-journey-optimizer/api-reference.md Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/public-classes-and-enum/index.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/public-classes-and-enum/message.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/public-classes-and-enum/messaging-push-payload.md Outdated Show resolved Hide resolved
...ges/edge/adobe-journey-optimizer/push-notification/android/automatic-display-and-tracking.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/push-notification/android/manual-display-and-tracking.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/push-notification/android/manual-display-and-tracking.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/push-notification/android/manual-display-and-tracking.md Outdated Show resolved Hide resolved
src/pages/edge/adobe-journey-optimizer/push-notification/tabs/push-payload.md Outdated Show resolved Hide resolved
calebk1
calebk1 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PravinPK PravinPK merged commit 51fbcf0 into AdobeDocs:main Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebk1 calebk1 calebk1 approved these changes

@sbenedicadb sbenedicadb Awaiting requested review from sbenedicadb

@swarna04 swarna04 Awaiting requested review from swarna04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PravinPK @calebk1