Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration docs #453

Merged
merged 15 commits into from
Nov 28, 2023
Merged

Migration docs #453

merged 15 commits into from
Nov 28, 2023

Conversation

praveek
Copy link
Contributor

@praveek praveek commented Nov 9, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments. Looks good (content-wise), but just a gatsby-config change.

gatsby-config.js Outdated
Comment on lines 705 to 730
},{
title: "Migration",
path: "/resources/migration",
pages: [{
title: "Android",
path: "/resources/migration/android",
pages: [{
title: "Migrate to Android 2.x SDKs",
path: "/resources/migration/android/migrate-to-android-2x"
}
]
},
{
title: "iOS",
path: "/resources/migration/ios",
pages: [{
title: "Migrate to iOS 3.x SDKs",
path: "/resources/migration/ios/migrate-to-ios-3x"
},
{
title: "Migrate to iOS 4.x SDKs",
path: "/resources/migration/ios/migrate-to-ios-4x"
}
]
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a sub-page to resource, this can just be listed as a subpage under resources (so, similarly to path: "/resources/upgrade-platform-sdks",).

Copy link
Contributor Author

@praveek praveek Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calebk1 I wanted to keep this section at the top level similar to User Guides. I placed the content in the resources directory, following the same approach used for 'User Guides'. Let me know if you need me to move it out of resources.

src/pages/resources/migration/ios/migrate-to-ios-4x.md Outdated Show resolved Hide resolved
src/pages/resources/migration/android/index.md Outdated Show resolved Hide resolved
gatsby-config.js Outdated Show resolved Hide resolved
gatsby-config.js Outdated Show resolved Hide resolved
@praveek praveek marked this pull request as ready for review November 9, 2023 23:23

Kotlin

<Tabs query="lang=kotlin"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try using CodeBlock for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I did not change current content w.r.t code samples.

Copy link
Contributor

@swarna04 swarna04 Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! I thought this was new code...
@calebk1 Can you make a note to update this whenever you get a chance using the CodeBlock? It will help clean up a lot of code clutter.

src/pages/resources/migration/ios/migrate-to-3x.md Outdated Show resolved Hide resolved
| Adobe Analytics | [AEPAnalytics](https://developer.adobe.com/client-sdks/previous-versions/documentation/adobe-analytics/migration) |
| Adobe Analytics - Media Analytics for Audio & Video | [AEPMedia](https://developer.adobe.com/client-sdks/previous-versions/documentation/adobe-media-analytics/migration) |
| Adobe Audience | [AEPAudience](https://developer.adobe.com/client-sdks/previous-versions/documentation/adobe-audience-manager/migration) |
| Adobe Experience Platform Target | [AEPTarget](https://developer.adobe.com/client-sdks/previous-versions/documentation/adobe-target/migration) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We are sending the user to the previous versions doc here. Let us see how this works out!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bring these docs in the current repo in future to prevent sending user to the old repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be fine to keep the previous-versions links for these docs for now

func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
let appState = application.applicationState
MobileCore.registerExtensions([Signal.self, Lifecycle.self, UserProfile.self, Identity.self, Assurance.self], {
MobileCore.configureWith(appId: "yourAppId")
Copy link
Contributor

@swarna04 swarna04 Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "yourAppId" -> "<your-environment-file-ID>", same comment for obj-c code sample.

Copy link
Contributor

@swarna04 swarna04 Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry about this, the angle brackets had to be escaped to show up properly. I didn't mean for it to be replaced with empty strings rather <your-environment-file-ID> to be consistent.

@swarna04
Copy link
Contributor

Looks good 👍 Left a comment for a super minor update.

gatsby-config.js Show resolved Hide resolved
src/pages/resources/faq.md Outdated Show resolved Hide resolved
src/pages/resources/migration/android/migrate-to-2x.md Outdated Show resolved Hide resolved
src/pages/resources/migration/android/migrate-to-2x.md Outdated Show resolved Hide resolved
src/pages/resources/migration/android/migrate-to-2x.md Outdated Show resolved Hide resolved
src/pages/resources/migration/ios/migrate-to-3x.md Outdated Show resolved Hide resolved
src/pages/resources/migration/ios/migrate-to-3x.md Outdated Show resolved Hide resolved
src/pages/resources/migration/ios/migrate-to-4x.md Outdated Show resolved Hide resolved
src/pages/resources/migration/ios/tabs/migrate-to-3x.md Outdated Show resolved Hide resolved
@emdobrin emdobrin merged commit b89501b into AdobeDocs:main Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants