-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration docs #453
Migration docs #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments. Looks good (content-wise), but just a gatsby-config change.
gatsby-config.js
Outdated
},{ | ||
title: "Migration", | ||
path: "/resources/migration", | ||
pages: [{ | ||
title: "Android", | ||
path: "/resources/migration/android", | ||
pages: [{ | ||
title: "Migrate to Android 2.x SDKs", | ||
path: "/resources/migration/android/migrate-to-android-2x" | ||
} | ||
] | ||
}, | ||
{ | ||
title: "iOS", | ||
path: "/resources/migration/ios", | ||
pages: [{ | ||
title: "Migrate to iOS 3.x SDKs", | ||
path: "/resources/migration/ios/migrate-to-ios-3x" | ||
}, | ||
{ | ||
title: "Migrate to iOS 4.x SDKs", | ||
path: "/resources/migration/ios/migrate-to-ios-4x" | ||
} | ||
] | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a sub-page to resource, this can just be listed as a subpage under resources (so, similarly to path: "/resources/upgrade-platform-sdks",
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calebk1 I wanted to keep this section at the top level similar to User Guides
. I placed the content in the resources
directory, following the same approach used for 'User Guides'. Let me know if you need me to move it out of resources.
src/pages/resources/migration/android/tabs/migrate-to-android-2x.md
Outdated
Show resolved
Hide resolved
|
||
Kotlin | ||
|
||
<Tabs query="lang=kotlin"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try using CodeBlock for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I did not change current content w.r.t code samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! I thought this was new code...
@calebk1 Can you make a note to update this whenever you get a chance using the CodeBlock
? It will help clean up a lot of code clutter.
| Adobe Analytics | [AEPAnalytics](https://developer.adobe.com/client-sdks/previous-versions/documentation/adobe-analytics/migration) | | ||
| Adobe Analytics - Media Analytics for Audio & Video | [AEPMedia](https://developer.adobe.com/client-sdks/previous-versions/documentation/adobe-media-analytics/migration) | | ||
| Adobe Audience | [AEPAudience](https://developer.adobe.com/client-sdks/previous-versions/documentation/adobe-audience-manager/migration) | | ||
| Adobe Experience Platform Target | [AEPTarget](https://developer.adobe.com/client-sdks/previous-versions/documentation/adobe-target/migration) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We are sending the user to the previous versions doc here. Let us see how this works out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should bring these docs in the current repo in future to prevent sending user to the old repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be fine to keep the previous-versions links for these docs for now
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { | ||
let appState = application.applicationState | ||
MobileCore.registerExtensions([Signal.self, Lifecycle.self, UserProfile.self, Identity.self, Assurance.self], { | ||
MobileCore.configureWith(appId: "yourAppId") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "yourAppId" -> "<your-environment-file-ID>", same comment for obj-c code sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry about this, the angle brackets had to be escaped to show up properly. I didn't mean for it to be replaced with empty strings rather <your-environment-file-ID>
to be consistent.
Looks good 👍 Left a comment for a super minor update. |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: