Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coding standard from PSR-2 to PSR-12 #141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jlnarvaez
Copy link
Contributor

@jlnarvaez jlnarvaez commented Apr 10, 2023

Purpose of this pull request

This pull request (PR) updates PSR-2 to PSR-12 that is a extended version of deprecated PSR-2.
Extracted from official documentation:

Deprecated - As of 2019-08-10 PSR-2 has been marked as deprecated. PSR-12 is now recommended as an alternative.

Affected pages

Links to Magento Open Source code

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlnarvaez, but there's already a PR open for this update that I'm trying to validate with internal teams (#92).

@jeff-matthews
Copy link
Contributor

Actually, I'm going to reopen your PR @jlnarvaez because you've signed the Adobe CLA and the contributor who opened #92 has not.

@jeff-matthews jeff-matthews reopened this Apr 12, 2023
@jeff-matthews jeff-matthews self-assigned this Apr 12, 2023
@jeff-matthews
Copy link
Contributor

Need to wait for the PR in the coding standards repo to be merged before updating docs.

magento/magento-coding-standard#416

@jeff-matthews jeff-matthews added the editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
Status: 🧊 On Hold
Development

Successfully merging this pull request may close these issues.

2 participants