Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove harmful warning Update plugins.md #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kirmorozov
Copy link

@kirmorozov kirmorozov commented Sep 17, 2024

Align with Mage-OS.
Around plugins are good and explicitly show up in a stack trace, performance degradation is near-non-existent by comparison with hours of debugging and understanding combinations of plugins. https://devdocs.mage-os.org/docs/main/plugins#content-2-after-plugin

Purpose of this pull request

This pull request (PR) removes harmful message that questions competence of those who write around plugins.
Having plugin in the stack eliminates hours of debugging.

Current message forces people to break down into before and after, when it actually does not make sense.

Thankfully Mage-OS did not keep this harmful statement.

Affected pages

  • plugins

Links to Magento Open Source code

  • none

Align with Mage-OS.
Around plugins are good and explicitly show up in a stack trace, performance degradation is minuscule by comparison with hours of debugging and understanding combinations of plugins.
https://devdocs.mage-os.org/docs/main/plugins#content-2-after-plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Needs Review
Development

Successfully merging this pull request may close these issues.

1 participant