Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conflict #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix conflict #57

wants to merge 1 commit into from

Conversation

TsehaynehGetaneh
Copy link
Collaborator

No description provided.

@TsehaynehGetaneh TsehaynehGetaneh self-assigned this Mar 28, 2023
YiseBoge
YiseBoge approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@YiseBoge YiseBoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but two points

  • follow the branch naming conventions (rename it now)
  • once approved, before squash merging, use more descriptive commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiseBoge YiseBoge YiseBoge approved these changes

Assignees

@TsehaynehGetaneh TsehaynehGetaneh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TsehaynehGetaneh @YiseBoge