fix stake page should use fetchWalletBalances thunk async action #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xcryptovenom is attempting to deploy a commit to the adrena Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adrena-orex
added a commit
that referenced
this pull request
Nov 25, 2024
* contrib: refactor fetching of wallet token balances using Redux (#447) * contrib: add reselect dependency (same version as the one used by rtk-query) Enables memoization of Redux selectors * contrib: add selectors directory w/ selectWalletAddress + selectWalletPublicKey memoized selector * contrib: refactor token balances fetching using Redux - remove useWatchWalletBalance hook in favor of a fetchWalletTokenBalances thunk action. - remove props drilling from the App component to all component which may need to fetch token balances by using the fetchWalletTokenBalances thunk action. - the same pattern can be applied to most custom hooks in the code base. it allows separating business logic from the UI, better architecture which also improves testability. it will have a good impact on rendering performance with wider adoption in the code base. - clean-up walletBalances actions: - use type inference - define constant action type & use it in the matching reducer - use concise definition of action creators: a simple function returning an action object * contrib: fix wallet token balances should reset when user disconnects * contrib: fix fetchWalletTokenBalances typing issue * fix stake page should use fetchWalletBalances thunk async action (#578) * duplicate username fix (#579) * Sunday nits2 (#580) * Staking popup mobile * Disable upgrade when not established * Display correct borrow rate for short * Remove automation from Monitoring Full * Add SquadX support (#582) * Volume chart (#583) --------- Co-authored-by: Venom <[email protected]> Co-authored-by: Tyro <[email protected]>
adrena-tyro
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #447
Cherry-picked from #577