Skip to content

Commit

Permalink
Qondra
Browse files Browse the repository at this point in the history
  • Loading branch information
kirillkrylov committed Nov 2, 2023
1 parent f1aca19 commit 1751432
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 7 deletions.
19 changes: 19 additions & 0 deletions .github/workflows/qodana_code_quality.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Qodana
on:
workflow_dispatch:
pull_request:
push:
branches:
- master

jobs:
qodana:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: 'Qodana Scan'
uses: JetBrains/[email protected]
env:
QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
10 changes: 3 additions & 7 deletions clio/Utilities/PowerShellFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@

namespace Clio.Utilities
{

Check notice on line 7 in clio/Utilities/PowerShellFactory.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

Use preferred namespace body style

Convert to file-scoped namespace
public interface IPowerShellFactory
public interface IPowerShellFactory : IDisposable
{
string ComputerName { get; }
void Dispose();
PowerShell GetInstance();
void Initialize(string userName, string password, string computerName);
}

public class PowerShellFactory : IDisposable, IPowerShellFactory
public class PowerShellFactory : IPowerShellFactory

Check notice on line 15 in clio/Utilities/PowerShellFactory.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

Class with virtual (overridable) members never inherited (non-private accessibility)

Class 'PowerShellFactory' has some virtual members but no inheritors
{

private bool _disposed = false;
Expand All @@ -28,10 +27,7 @@ public class PowerShellFactory : IDisposable, IPowerShellFactory
private SecureString SecureString { get; set; }

private WSManConnectionInfo ConnectionInfo { get; set; }

public PowerShellFactory()
{
}


public void Initialize(string userName, string password, string computerName)
{
Expand Down
29 changes: 29 additions & 0 deletions qodana.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#-------------------------------------------------------------------------------#
# Qodana analysis is configured by qodana.yaml file #
# https://www.jetbrains.com/help/qodana/qodana-yaml.html #
#-------------------------------------------------------------------------------#
version: "1.0"

#Specify inspection profile for code analysis
profile:
name: qodana.starter

#Enable inspections
#include:
# - name: <SomeEnabledInspectionId>

#Disable inspections
#exclude:
# - name: <SomeDisabledInspectionId>
# paths:
# - <path/where/not/run/inspection>

#Execute shell command before Qodana execution (Applied in CI/CD pipeline)
#bootstrap: sh ./prepare-qodana.sh

#Install IDE plugins before Qodana execution (Applied in CI/CD pipeline)
#plugins:
# - id: <plugin.id> #(plugin id can be found at https://plugins.jetbrains.com)

#Specify Qodana linter for analysis (Applied in CI/CD pipeline)
linter: jetbrains/qodana-dotnet:latest

0 comments on commit 1751432

Please sign in to comment.