Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream #496

Merged
merged 1,332 commits into from
Sep 20, 2024
Merged

Upstream #496

merged 1,332 commits into from
Sep 20, 2024

Conversation

Schrodinger71
Copy link
Collaborator

@Schrodinger71 Schrodinger71 commented Sep 17, 2024

О пулл реквесте

АПСТРИМ!!

@Darkiich пуська

Требования

  • Я прочитал(а) и следую Руководство по созданию пулл реквестов. Я понимаю, что в противном случае мой ПР может быть закрыт по усмотрению мейнтейнера.
  • Я добавил скриншоты/видео к этому пулл реквесту, демонстрирующие его изменения в игре, или этот пулл реквест не требует демонстрации в игре

Критические изменения

Чейнджлог

🆑 Шрёдька

  • tweak: Подтянуты коммиты с Корвакса, 17.09.24

lzk228 and others added 30 commits September 6, 2024 02:22
* Cleanup books.yml

* yeah

* shame
* Vox sign/N2 locker update

The "vox area" sign and N2 locker sprite were both taken from /vg/station. These sprites have bad racist connotations as discussed in space-wizards/space-station-14#31840, and do not fit our server culture.

The new N2 locker is not a taped on piece of trash. It now also has a blue stripe to mimic the regular O2 locker and make it more distinct from fire safety closets.

The new "vox area" sign sprite follows the same style as other "area indicator" signs used throughout the blue and isn't an explicit warning sign anymore. It still has "No O2" on it to fill that role though.

* emogarbage adjustments

---------

Co-authored-by: EmoGarbage404 <[email protected]>
Pizza box now contains cotton pizza

Co-authored-by: Ekkosangen <[email protected]>
* A

* B

* C

* D

* Update TechAnomalySystem.cs

* idle anim

* Update meta.json

* new animation
…, and I am mad (#31246)

* Fix logging of GetWebhook errors

Yeah let's just not log the error only stack trace.

* I have spent more time today cleaning up garbage than coding new shit, and I am mad

Cleans up the custom vote Discord webhook code because I *happened* to lay my eyes on how completely terrible it was and immediately found an obvious bug with it.

Also did basic QA because jesus christ: it more clearly reports pending votes, properly indicates cancelled votes, improves footer formatting, better error logging, all the usual shit.

Requires space-wizards/RobustToolbox#5375 to avoid test failures
* Mineral Scanner

* doink

* review

* sunday funday

* review and fix bugs i think?

* Update MiningOverlay.cs
* Fix ai upload console itemslot whitelist

* aw man
vox laugh not underwater
* fix shotgun sprite

* fix take 2
pest events reorganized and snails spawn
* break pull at sleep

* TryStopPull without user

---------

Co-authored-by: YourUsername <[email protected]>
…tegories: [ HideSpawnMenu ] + self recharge removed + 1 more shot + normal recharge speed (#31235)

* narrow nerf

* last instance of nospawn gone

* removes self recharge

* 8 shots, less recharge time
* Add justice helm

* backslash moment

* spinny light

* remove power cell from recipe
Deleting binary key

Silicon supremacy!
# Conflicts:
#	Resources/Prototypes/Entities/Mobs/Player/admin_ghost.yml
#	Resources/Prototypes/Entities/Objects/Misc/books.yml
#	Resources/Prototypes/Maps/cog.yml
#	Resources/Textures/Objects/Storage/boxes.rsi/meta.json
#	Resources/Textures/Structures/Wallmounts/signs.rsi/meta.json
* split temperature protection into heating and cooling

* fugg

* weh
@Schrodinger71
Copy link
Collaborator Author

ЗАебал

@Mirokko
Copy link
Contributor

Mirokko commented Sep 20, 2024

Я кучу всего написал, но случайно закрыл. В общем, изменения в конфигурации, на которые нам (возможно) надо обратить внимание:
ahelp.admin_prefix
ahelp.admin_prefix_webhook
atmos.max_explosion_range

@Mirokko
Copy link
Contributor

Mirokko commented Sep 20, 2024

Я поверхносно глянул, всё вроде норм (кроме переводов, их бы тоже подтянуть, но в отдельном МРе).
LGTM!

@PyotrIgn
Copy link
Contributor

Возьму сейчас немного баги апстрима подчинить. Если кто-то с ним сейчас работает - оповестите

@Schrodinger71 Schrodinger71 merged commit 0047532 into master Sep 20, 2024
13 of 14 checks passed
@Schrodinger71 Schrodinger71 deleted the upstream1709 branch September 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Изменение локализации Changes: Map Изменение карт Changes: Sprites Изменение спрайтов Changes: UI Изменение интерфейса
Projects
None yet
Development

Successfully merging this pull request may close these issues.