-
Notifications
You must be signed in to change notification settings - Fork 70
Conversation
Current coverage is 87.25% (diff: 100%)@@ master #100 diff @@
==========================================
Files 28 28
Lines 1914 1914
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1670 1670
Misses 244 244
Partials 0 0
|
@aeroaks I would like to keep the |
@aqreed We agreed the other day not to duplicate the examples - it's true that we need tests, but those should be unit tests. Keeping two versions of the examples is a mess, I'm -1 on keeping the .py files. |
@aqreed I have not used it but I think that there is a way in which you can convert notebook file to scripts. |
@Juanlu001 well I do think py examples and nb examples should be two separate entities, Jupyter notebooks are a good thing but we should not impose its use neither to visitors or to developers. |
I am +1 to having both notebooks and .py's. Notebooks are nice but annoying for fast checks and copypastes. |
reorder of examples as nb & scripts
Pending review:
Who wants to review the pull request based on these bullet points? You can check out the changes using these commands:
|
When doing @aeroaks I will send you a pull request with the modifications get all the plots in the examples 006 and 007 (my bad, I forgot to uncomment some of them in the previous PR). Also, example 005 was left executed too so I cleaned it up. |
You have to run your script with ipython:
Then get_ipython will be already in global context. |
By the way, it seems like the conversion template con be modified, in case it's interesting: http://nbconvert.readthedocs.io/en/latest/customizing.html This is the default one: https://github.com/jupyter/nbconvert/blob/master/nbconvert/templates/python.tpl |
I have merged the branch so now can have both options at the same time. Nevertheless, as I see that @aqreed seems has more changes to do, we can discuss them in a new pull request |
Regarding #95