-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a ct.get_all_results() implementation #1901
base: develop
Are you sure you want to change the base?
Adding a ct.get_all_results() implementation #1901
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1901 +/- ##
===========================================
+ Coverage 84.49% 84.89% +0.39%
===========================================
Files 295 181 -114
Lines 14472 11287 -3185
Branches 195 0 -195
===========================================
- Hits 12228 9582 -2646
+ Misses 2110 1705 -405
+ Partials 134 0 -134
*This pull request uses carry forward flags. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is the same as what was there before, but the bot thinks it's better format wise
Added an implementation of the
get_all_results
function desired in #1701 . The main issue with the current implementation I've added is that it requires either of the following.If these requirements are not met, the provided implementation will not work. The internal documentation I've provided explains the logic on how everything works. I have not yet updated the external documentation. No tests have been written to test this function yet.