set up MOS for full-duplex comms #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sets up UART0 to do both RTS and CTS `wait_ESP32` now does a pure wait, with no timeout, as an Agon can’t operate without a working VDP, and the VDP hasn’t supported the lower baud rate in forever. it will call the “general poll” command sending a value of 2, which will trigger a compliant VDP to switch to full duplex from experimentation it seems that MOS doesn’t actually really need to care whether the VDP _actually_ switches over to full-duplex mode or not - it will carry on working regardless includes a fix to `UART1_serial_GETCH` which was looking at the incorrect flag bit to determine if UART1 was connected - it was looking at the bit for UART0 so would always find a connection based on a PR to Quark by S0urceror, but with a few additional changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sets up UART0 to do both RTS and CTS
wait_ESP32now does a pure wait, with no timeout, as an Agon can’t operate without a working VDP, and the VDP hasn’t supported the lower baud rate in forever.on successful receipt of a “general poll” response it now sends a "set feature flag" command to switch the VDP to use full duplex comms
from experimentation it seems that MOS doesn’t actually really need to care whether the VDP actually switches over to full-duplex mode or not - it will carry on working regardless, therefore no checking is done to verify the switch has happened
includes a fix to
UART1_serial_GETCHwhich was looking at the incorrect flag bit to determine if UART1 was connected - it was looking at the bit for UART0 so would always find a connectionbased on a PR to Quark by S0urceror (breakintoprogram/agon-mos#126), but with a few additional changes