rc1 verification - reapply upgrade #10484
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
006ae98
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://120068e6.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mk-test-upgrade-reapply.agoric-sdk.pages.dev |
This reverts commit a146d15.
Chris-Hibbert
approved these changes
Nov 19, 2024
Comment on lines
+6
to
+8
| // This query matches both the auction and its governor, so 2*3 for the | ||
| // original, the vaults&auctions coreEval, and the priceFeed coreEval. | ||
| t.is(Object.keys(details).length, 8); |
There was a problem hiding this comment.
Suggested change
| // This query matches both the auction and its governor, so 2*3 for the | |
| // original, the vaults&auctions coreEval, and the priceFeed coreEval. | |
| t.is(Object.keys(details).length, 8); | |
| // This query matches both the auction and its governor, so 2*4 for the | |
| // original, the vaults&auctions coreEval, upgrade 18 (plus the re-run on emerynet). | |
| t.is(Object.keys(details).length, 8); |
mujahidkay
added a commit
that referenced
this pull request
Nov 19, 2024
## Description Cherry-picks the following commits from master: - #10454 (d16781f) - #10455 (1aec8d0) Also adds a new upgrade name `agoric-upgrade-18-basic-2`. Also, moves provisioning GOV4 from USE to PREPARE. used `git cherry-pick` for the above commits [Draft PR with reapply upgrade on top of rc0](#10484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Intended to remain draft. Only needed for verification purposes