feat: nix improvements for modularity #11032
Open
+125
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
28fa65e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78cc5e34.agoric-sdk.pages.dev |
| Branch Preview URL: | https://jeancarlobarrios-nix-improve.agoric-sdk.pages.dev |
Deploying agoric-sdk with
|
| Latest commit: |
4f5990c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0f93139.agoric-sdk.pages.dev |
| Branch Preview URL: | https://jeancarlobarrios-nix-improve.agoric-sdk.pages.dev |
Deploying agoric-sdk with
|
| Latest commit: |
3d72064
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53e26696.agoric-sdk.pages.dev |
| Branch Preview URL: | https://jeancarlobarrios-nix-improve.agoric-sdk.pages.dev |
Deploying agoric-sdk with
|
| Latest commit: |
45b927b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1c770283.agoric-sdk.pages.dev |
| Branch Preview URL: | https://jeancarlobarrios-nix-improve.agoric-sdk.pages.dev |
JeancarloBarrios
force-pushed
the
JeancarloBarrios/nix-improvements
branch
from
45b927b to
5c0c447
Compare
Deploying agoric-sdk with
|
| Latest commit: |
5c0c447
|
| Status: | ⚡️ Build in progress... |
Deploying agoric-sdk with
|
| Latest commit: |
5c0c447
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f0c74f5.agoric-sdk.pages.dev |
| Branch Preview URL: | https://jeancarlobarrios-nix-improve.agoric-sdk.pages.dev |
|
@dckc I believe you will like this version better. It does not download from Node but pulls for nix pkg, and it uses an overlay to override the version. I'm modularizing it to prepare it for some proto tolling I need to add for the Cosmos side. I also tried to improve its clarity. |
michaelfig
reviewed
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the flake stack to be more modular, and easy to read, getting ready for a proto tooling inclution