feat(internal): Miscellaneous improvements #11040
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
defineName
utility for naming otherwise anonymous functions.Fail
andq
).Security Considerations
Using the
Fail
polyfill without SES (or importing it before SES) will produce errors with censorship-free messages. This is expected only for scenarios in which SES is not loaded at all, but if we are concerned, then it could incorporate a time-of-use check that e.g.globalThis.Fail
and/orglobalThis.assert?.Fail
are undefined (or thatglobalThis.lockdown
is, or whatever we deem to be the best predicate for detecting SES).Scaling Considerations
n/a
Documentation Considerations
No new concerns, although we could definitely do a better job of documented what's in package "internal" and how to use it.
Testing Considerations
These are likewise lacking. I suppose a lot could be cribbed from Endo.
Upgrade Considerations
n/a