-
Notifications
You must be signed in to change notification settings - Fork 226
Code Review Checklist
Turadg Aleahmad edited this page Feb 5, 2025
·
15 revisions
See also Coding Style
If the PR is adding dependencies, those should be assessed themselves.
- If it’s going on chain, review carefully and try hard not to take it on.
- If it’s going in external NPM dependencies for using agoric-sdk, assess whether it’s safe to run on users’ machines.
- If it’s going into local devDependencies assess whether it’s safe to run on OpCo machines.
There’s also some consideration of whether the package will be well maintained, but that’s only for stuff that may require maintenance.
Finally, look in yarn.lock
for the transitive dependencies and assess those as well.
This wiki is for developing agoric-sdk. For help using Agoric SDK, see https://docs.agoric.com/ and https://agoric-sdk.pages.dev/