feat: remove wallet-app bridge #92
Conversation
Deploying with
|
| Latest commit: |
500367f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab8ef606.dapp-psm.pages.dev |
| Branch Preview URL: | https://remove-wallet-bridge.dapp-psm.pages.dev |
samsiegart
force-pushed
the
remove-wallet-bridge
branch
from
39cba2d
to
d44d952
Compare
|
@samsiegart |
Text change: 'You will need 10BLD to fund it's provision which will be deposited to the community fund.' 
- isn't this an insufficent BLD funds message? Can we change to 'Insufficient BLD funds. Please ensure you have 10BLD and try again. ...agorxxxxx does not exist on chain'
|
| @@ -6,7 +6,6 @@ | |||
| "scripts": { | |||
| "dev": "vite", | |||
| "build": "tsc && vite build", | |||
| "postinstall": "patch-package", | |||
| @@ -31,7 +35,6 @@ const App = () => { | |||
| width="200" | |||
| /> | |||
| </a> | |||
| <WalletBridge /> | |||
| chainConnection.watcher.rpcAddr | ||
| ); | ||
| console.debug('swingset params', params); | ||
| setFee(BigInt(params.params.powerFlagFees[0].fee[0].amount)); |
There was a problem hiding this comment.
Another use case for theOne. Let's look for these through the dapps once we have that.
There was a problem hiding this comment.
In this instance at least we handle the error gracefully on line 103
|
|
||
| export type SwingsetParams = { foo: string }; | ||
|
|
||
| const feeDenom = 10n ** 6n; |
There was a problem hiding this comment.
Can't we get this from vstorage?
There was a problem hiding this comment.
I think it should be available under published.agoricNames.vbankAsset although the wallet-app has the same logic as here. My assumption is that changing the actual denom would be a significant change that would allow for some lead time to update, but might be good to confirm that.
| // Increment every time the current terms change. | ||
| export const currentTermsIndex = 1; | ||
|
|
||
| export type SwingsetParams = { foo: string }; |
There was a problem hiding this comment.
Ah yea, I was originally trying to pass in the whole params, and created this type before I knew how they were structured. I changed this to only pass in the amount value, and handle any parsing errors in ChainConnection.tsx where the params are loaded, so this is unused. Removed.
|
@otoole-brendan I updated the text as requested for the provisioning message. For the error message, that comes from Keplr before it even broadcasts the txn to the chain. It's difficult to make it user-friendly. We could have some logic that parses the text, tries to identify the error, and translates it into something more understandable, but that logic would break if Keplr ever changed the message themselves. |
fixes #91
Live demo: https://remove-wallet-bridge.dapp-psm.pages.dev/