[Release] quick fx for render passes

Agrael1 · Oct 23, 2024 · 6b2faab · 6b2faab
1 parent 13626db
commit 6b2faab
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -20,7 +20,7 @@
 
 cmake_minimum_required(VERSION 3.22)
 
-set(WISDOM_VERSION "0.3.7")
+set(WISDOM_VERSION "0.3.8")
 project("Wisdom" VERSION ${WISDOM_VERSION})
 
 set(CMAKE_DEBUG_POSTFIX d)

diff --git a/Changelog.md b/Changelog.md
@@ -1,5 +1,9 @@
 # Version History
 
+- 0.3.8
+
+  - Fixed render pass for DX12 always clearing, despite of value
+
 - 0.3.7
 
   - Added specific function for creating depth stencil views

diff --git a/wisdom/include/wisdom/dx12/impl/dx12_command_list.cpp b/wisdom/include/wisdom/dx12/impl/dx12_command_list.cpp
@@ -222,7 +222,7 @@ void wis::ImplDX12CommandList::BeginRenderPass(const wis::DX12RenderPassDesc* pa
                     .Type = convert_dx(target.store_op),
             }
         };
-        if (data[i].BeginningAccess.Type = D3D12_RENDER_PASS_BEGINNING_ACCESS_TYPE_CLEAR) {
+        if (data[i].BeginningAccess.Type == D3D12_RENDER_PASS_BEGINNING_ACCESS_TYPE_CLEAR) {
             std::copy(std::begin(target.clear_value), std::end(target.clear_value), std::begin(data[i].BeginningAccess.Clear.ClearValue.Color));
         }
     }