Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate the init steps for dapp #1

Open
wants to merge 1 commit into
base: build/preview-11
Choose a base branch
from

Conversation

sreuland
Copy link

there was some corner cases in dapp init, suggestion here to funnel everything through npm run reset, don't tell users to run any .sh scripts directly, leads to incomplete init states. always purge the target directory, as it was previously left dirty and contract bindings were pulling that older contract code.

@sreuland
Copy link
Author

sreuland commented Oct 2, 2023

@chadoh, I tested the following back-back scenario between networks, to check reset behavior:

# test standalone
quickstart.sh standalone &
NETWORK=standalone npm run reset
npm run dev
# dapp worked, able to min/pledge
#
# test futurenet
npm run reset
npm run dev
# dapp worked, able to min/pledge

the only functional change here from your branch is that clean is removing the target directory, which was where I had encountered problems due to having run the dapp prior and target was dirtly with old stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant