Sync this repository with Stellar's #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* build: directly generate js libs to node_modules Roll back #122, but keep `crowdfund-contract` and `abundance-token` in `optionalDependencies`. As I worked with the old version in earnest, iterating on a local copy of the CLI and generating new JS libs over and over, the two-step generate-to-.soroban, then install-to-node_modules wasn't working very well. Probably because the new library wasn't being added until the `postinstall` step, and the dependencies are optional. Generating directly to `node_modules` feels dirty, but it works consistently. At least in this version, you can still see the dependencies listed in the `optionalDependencies` section, so they're not quite as surprising/mysterious. * build: try adding back optionalDeps * build: update node; use preinstall and local deps * Update package-lock.json * work around a bug in the binding gen --------- Co-authored-by: Chad Ostrowski <[email protected]>
build: fix nvmrc (can't use range)
- Pin soroban-cli to latest commit from stellar/stellar-cli#973. This PR will be mergeable once a new quickstart image is released and we can verify that its tests pass. - Update the contract's SDK version - Copy in abundance source from token contract at "Changes for the next release," stellar/soroban-examples#277. Note that I did not author most of the changes in the contracts/abundance folder. I only copied in the changes originally authored by @leighmcculloch, then updated for the single tweak that this abundance contract already had: 1. comments on the mint method; and 2. slightly modified mint behavior. - New CLI's typescript-bindings-generated libraries export a `Contract` class, rather than a flat bag of functions. Instantiating these contracts is now taken care of in `shared/contracts.ts`, with code throughout the rest of the codebase referencing these instances. - Instantiating these classes required access to the `network` and `rpcUrl` used with the `initialize.sh` script. NextJS doesn't allow reading the files we already write (like `.soroban-example-dapp/network`), so for now I've also `echo`d relevant values to a `shared/config.json` file, which is hidden. This could probably be cleaned up in the future by putting all relevant settings in an `.env` file, and cleaning up the package.json scripts to use `dotenv cross-env` or similar.
build: update for preview 11
Signed-off-by: Satyam Zode <[email protected]>
Build and test the MSRV and latest
Add rust-toolchain.toml
Update ubuntu to 22.04 from 20.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync this repository with the stellar repository