Prevent false positives for SQL keywords #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae9ab6f.
SELECT * FROM users WHERE id = 1;
if "SELECT" occurs somewhere in the body, query parameters, ... the
query will be flagged as SQL injection
If the user input is exactly an SQL keyword, we can ignore it.
It's only when keywords are combined with other things...
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
| SQL_STRING_CHARS, | ||
| } from "./config"; | ||
|
|
||
| t.test("SQL_KEYWORDS are valid", async () => { |
There was a problem hiding this comment.
what is meant by valid here?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Updated the test names 👍
library/vulnerabilities/sql-injection/userInputContainsSQLSyntax.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.