Correct single RGB & DRGB modes to explicitly utilize white

[mxklb]

Using availDMXLen to choose to utilize white channel is messy because it has nothing to do with ability of the strip. It is the number of channels available in the E1.31/Artnet package. Additional this may lead to unexpected behavior if subsequent DMX start addresses for multiple WLED controllers shall be used.

The approach here is clear, if no white channel exist:

• Single RGB -> 3 DMX channels
• Single DRGB -> 4 DMX channels

And if white channel exists:

• Single RGB(W) -> 4 DMX channels
• Single DRGB(W) -> 5 DMX channels

So number of DMX channels for both modes is +1 if LEDs have white, else number of channels is as documented.

Note: Should be changed in documentation as well, shall be named Single RGB(W) and Single DRGB(W)

[blazoncek]

Please re-base this PR to 0_15 branch.

[blazoncek]

I do not use realtime data so cannot test this PR.
Still, as WLED allows realtime data to be displayed on main segment only, and main segment may not include white channel, it is mandatory to differentiate if the underlying canvas supports white properly.

Segment has light capabilities embedded (and recalculated on each change) and white channel presence can be determined by Segment::hasWhite() method.

[blazoncek]

Seems ok but please add parentheses. 😄

[mxklb]

@blazoncek please check bdd667d

I think it could be faster when only iterating over differentiated length as well, shall I add these checks again?

[blazoncek]

IDK. I have very little knowledge about realtime apart from DDP implementation.
If you can, do some testing and make appropriate changes if necessary. When you think it is ok just say so and I'll merge.

[mxklb]

I'll change back PR draft mode, when I've tested code changes with realtime DMX console e131 input.

[softhack007]

I'll change back PR draft mode, when I've tested code changes with realtime DMX console e131 input.

@mxklb did you make progress? This PR is in draft for 8 months now, are you still working on it?

mxklb force-pushed the e131-single branch from 0360497 to bdd667 7 months ago

PS: please don't force-push - it leads to many strange effects on github, including lost review comments.

[mxklb]

I forgot to test it. Implementaion looks still good, is an improvement.

I'll try to test it the following week, and will change draft mode, when everything works as expected.