Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from inliner to web-resource-inliner #4266

Open
wants to merge 1 commit into
base: 0_15
Choose a base branch
from

Conversation

w00000dy
Copy link
Contributor

@w00000dy w00000dy commented Nov 9, 2024

This migrates from the old inliner package to the web-resource-inliner package.

Now we don't get this warning anymore:

(node:29032) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

If you are wondering why the flash size increased, it is because the old inline package did not respect /*! these comments */ with exclamation marks.
Now, if you look at the source code, you can see the iro.js license.

Before:

RAM:   [=         ]  14.8% (used 48472 bytes from 327680 bytes)
Flash: [========= ]  86.8% (used 1365765 bytes from 1572864 bytes)

grafik

Now:

RAM:   [=         ]  14.8% (used 48472 bytes from 327680 bytes)
Flash: [========= ]  86.8% (used 1365845 bytes from 1572864 bytes)

grafik

This fixes #4166.

@softhack007 softhack007 added dependencies Pull requests that update a dependency file good job labels Dec 1, 2024
@softhack007 softhack007 added this to the 0.16.0 candidate milestone Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants