Add _all_ date function aliases to parser (extended) #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add all other AlaSQL date functions and aliases to the parser - Adjust unit tests, as month is now a reserved keyword - Explicitly didn't add the "DATE()" function, as it's use is very ambiguous in AlaSQL -> as column alias, as column type, as JS expression. - Added IntervalLiteral which contains all possible values to use when specifying an interval expression
- Use Expression instead of ExprList to restrict the number of arguments to the methods
- Extend unit test with non existing interval - DAYOFYEAR is alias for DAY
- Compact the expression with an OR statement to reduce duplicate code
|
I really like this, but im a bit sad to break lots of current implementation by making Over the Christmas break I will see if I can make this work so its only a protected keyword as the first parameter in the date functions, and other places we look for the name plus a |
|
Still working on this. Neck deep in the jungle of JISON. |
|
@mathiasrw i processed your comments and made some changes. |
mathiasrw
reviewed
Dec 21, 2024
|
Ill pick up the rest and work on it not being breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1980, this PR attempts to add all relevant date functions to the parser (and thus validate the query for being valid).
NOWGETDATECURRENT_DATE()ADDDATE(args)SUBDATE(args)DAY(date)DAYOFMONTH(date)DAYOFWEEK(date)DATE_ADD(args)DATE_SUB(args)SUBDATE(args)MINUTE(date)SECOND(date)MONTH(date)YEAR(date)WEEK(date)WEEKDAY(date)Additional: the interval values that can be specified are now also part of the parser:
This makes some keywords now reserved keywords, like using
monthas column alias for example.This has been adjusted in this PR.
Do note that
DATE()is not added to the parser, as its use is very ambigious in AlaSQL.There are new unit tests that verify the changes made.