Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflicts between gradle plugins and imports in multiplatform projects #3095

Closed
wants to merge 4 commits into from

Conversation

AngeloFilaseta
Copy link
Contributor

This PR should resolve the problem described in issue #3071
It seems like some plugins interfere with the import of classes between multiplatform projects.

Such plugins are:

  • application
  • ktor plugin
  • multi-jvm-test
  • javaQA

As a solution, I removed the application and ktor plugins from some MP projects. The others are still applied to JVM-only projects. If further investigation is required, I could make an attempt.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ee3007) 0.00% compared to head (a5b9759) 0.00%.
Report is 34 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3095   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines         115     106    -9     
  Branches        5       5           
======================================
+ Misses        115     106    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Feb 3, 2024

Hi @AngeloFilaseta! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

1 similar comment
Copy link
Contributor

mergify bot commented Feb 5, 2024

Hi @AngeloFilaseta! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

@AngeloFilaseta
Copy link
Contributor Author

I know dear robot, you already told me, I will do it, just keep calm

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

mergify bot commented Feb 9, 2024

Hi @AngeloFilaseta! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

@AngeloFilaseta AngeloFilaseta closed this by deleting the head repository Mar 7, 2024
@DanySK
Copy link
Member

DanySK commented Mar 7, 2024

what happened here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants