Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorconfigの改行コードLFの対象を全ファイルに変更する #903

Conversation

KentaHizume
Copy link
Contributor

  • Visual StudioにおけるJSON、XMLファイルの場合、追加>新しい項目>から追加した際に下記の通り特殊な挙動となります。
    • (現)デフォルトがの改行がCRLF、ファイル内に追加される改行もCRLF
    • (新)デフォルトの改行がCRLF、ファイル内に追加される改行はLF(ウィンドウ上の表記が「混合」の状態になる)

@KentaHizume KentaHizume added target: Dressca サンプルアプリケーションDresscaに関係がある target: ConsoleAppWithDI コンソールアプリケーションの要件別サンプルに関係がある labels Mar 12, 2024
@KentaHizume KentaHizume added this to the v0.8 milestone Mar 12, 2024
@KentaHizume KentaHizume self-assigned this Mar 12, 2024
Copy link

Test Result 📝

Test was a success.
Completed in 15058ms with 208 passed, 0 failed and 0 skipped.

Coverage 📐

Summary
Generated on: 03/12/2024 - 05:49:33
Coverage date: 03/12/2024 - 05:49:24 - 03/12/2024 - 05:49:27
Parser: MultiReport (3x Cobertura)
Assemblies: 6
Classes: 87
Files: 87
Line coverage: 59.8% (955 of 1596)
Covered lines: 955
Uncovered lines: 641
Coverable lines: 1596
Total lines: 5383
Branch coverage: 55.4% (173 of 312)
Covered branches: 173
Total branches: 312
Method coverage: Feature is only available for sponsors
Tag: 524_8244182489
Dressca.ApplicationCore - 86.4%
Name Line Branch
Dressca.ApplicationCore 86.4% 70.8%
Dressca.ApplicationCore.Accounting.Account 100% 100%
Dressca.ApplicationCore.Accounting.AccountItem 100%
Dressca.ApplicationCore.ApplicationCoreServicesExtensions 100%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService 100% 70%
Dressca.ApplicationCore.ApplicationService.CatalogApplicationService 100% 50%
Dressca.ApplicationCore.ApplicationService.OrderApplicationService 100% 75%
Dressca.ApplicationCore.ApplicationService.ShoppingApplicationService 100% 78.5%
Dressca.ApplicationCore.ApplicationService.TransactionScopeManager 100% 100%
Dressca.ApplicationCore.Assets.Asset 94.4% 62.5%
Dressca.ApplicationCore.Assets.AssetNotFoundException 100%
Dressca.ApplicationCore.Assets.AssetTypes 100% 100%
Dressca.ApplicationCore.Baskets.Basket 100% 100%
Dressca.ApplicationCore.Baskets.BasketItem 84.2% 75%
Dressca.ApplicationCore.Baskets.CatalogItemNotExistingInBasketException 100%
Dressca.ApplicationCore.Catalog.CatalogBrand 84.6% 100%
Dressca.ApplicationCore.Catalog.CatalogCategory 84.6% 100%
Dressca.ApplicationCore.Catalog.CatalogDomainService 100% 66.6%
Dressca.ApplicationCore.Catalog.CatalogItem 49.1% 37.5%
Dressca.ApplicationCore.Catalog.CatalogItemAsset 85.7% 50%
Dressca.ApplicationCore.Catalog.CatalogItemNotExistingInRepositoryException 100%
Dressca.ApplicationCore.Events 100%
Dressca.ApplicationCore.Ordering.Address 61.1% 100%
Dressca.ApplicationCore.Ordering.CatalogItemOrdered 90% 100%
Dressca.ApplicationCore.Ordering.EmptyBasketOnCheckoutException 100%
Dressca.ApplicationCore.Ordering.NullBasketOnCheckoutException 100%
Dressca.ApplicationCore.Ordering.Order 86% 71.4%
Dressca.ApplicationCore.Ordering.OrderFactory 0%
Dressca.ApplicationCore.Ordering.OrderItem 83.3% 37.5%
Dressca.ApplicationCore.Ordering.OrderItemAsset 85.7% 66.6%
Dressca.ApplicationCore.Ordering.OrderNotFoundException 100%
Dressca.ApplicationCore.Ordering.ShipTo 58.3% 50%
Dressca.ApplicationCore.Resources.Messages 85.4% 100%
Dressca.Store.Assets.StaticFiles - 9.4%
Name Line Branch
Dressca.Store.Assets.StaticFiles 9.4% 0%
Dressca.Store.Assets.StaticFiles.Events 0%
Dressca.Store.Assets.StaticFiles.Resources.Messages 0% 0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStore 0% 0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStoreServicesExtension 100%
Dressca.SystemCommon - 87.3%
Name Line Branch
Dressca.SystemCommon 87.3% 90%
Dressca.SystemCommon.BusinessError 100% 83.3%
Dressca.SystemCommon.BusinessErrorCollection 88.8% 100%
Dressca.SystemCommon.BusinessException 93.7% 100%
Dressca.SystemCommon.ObjectExtensions 80% 50%
Dressca.SystemCommon.Resources.Messages 55.5% 100%
Dressca.SystemCommon.Text.Json.DefaultJsonSerializerOptions 100%
Dressca.Web - 29.2%
Name Line Branch
Dressca.Web 29.2% 25.4%
Dressca.Web.Assets.AssetExtensions 87.5% 50%
Dressca.Web.Baskets.BuyerIdFilterAttribute 55.8% 20%
Dressca.Web.Baskets.HttpContextExtensions 100% 100%
Dressca.Web.Controllers.ActionNameHelper 0% 0%
Dressca.Web.Controllers.ApiModel.FindCatalogItemsQuery 0%
Dressca.Web.Controllers.AssetsController 0% 0%
Dressca.Web.Controllers.BasketItemsController 0% 0%
Dressca.Web.Controllers.CatalogBrandsController 0% 0%
Dressca.Web.Controllers.CatalogCategoriesController 0% 0%
Dressca.Web.Controllers.CatalogItemsController 0% 0%
Dressca.Web.Controllers.ErrorController 0% 0%
Dressca.Web.Controllers.OrdersController 0% 0%
Dressca.Web.Events 100%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider 7.8% 0%
Dressca.Web.Mapper.BasketItemMapper 0% 0%
Dressca.Web.Mapper.BasketMapper 0% 0%
Dressca.Web.Mapper.CatalogBrandMapper 0% 0%
Dressca.Web.Mapper.CatalogCategoryMapper 0% 0%
Dressca.Web.Mapper.CatalogItemMapper 0% 0%
Dressca.Web.Mapper.DtoMapperServicesExtension 100%
Dressca.Web.Mapper.OrderMapper 0% 0%
Dressca.Web.Resources.Messages 37% 100%
Dressca.Web.Runtime.BusinessExceptionDevelopmentFilter 100% 50%
Dressca.Web.Runtime.BusinessExceptionFilter 100% 50%
Dressca.Web.Runtime.BusinessExceptionFilterBase 100% 83.3%
Program 75% 66.6%
Dressca.Web.Dto - 0%
Name Line Branch
Dressca.Web.Dto 0% 0%
Dressca.Web.Dto.Accounting.AccountResponse 0%
Dressca.Web.Dto.Baskets.BasketItemResponse 0%
Dressca.Web.Dto.Baskets.BasketResponse 0%
Dressca.Web.Dto.Baskets.PostBasketItemsRequest 0%
Dressca.Web.Dto.Baskets.PutBasketItemsRequest 0%
Dressca.Web.Dto.Catalog.CatalogBrandResponse 0%
Dressca.Web.Dto.Catalog.CatalogCategoryResponse 0%
Dressca.Web.Dto.Catalog.CatalogItemResponse 0%
Dressca.Web.Dto.Catalog.CatalogItemSummaryResponse 0%
Dressca.Web.Dto.Ordering.OrderItemResponse 0%
Dressca.Web.Dto.Ordering.OrderResponse 0%
Dressca.Web.Dto.Ordering.PostOrderRequest 0%
Dressca.Web.Dto.PagedList`1 0% 0%
Maris.Logging.Testing - 94.2%
Name Line Branch
Maris.Logging.Testing 94.2% 100%
Maris.Logging.Testing.Xunit.TestLoggerManager 100% 100%
Maris.Logging.Testing.Xunit.XunitLogger 76.4% 100%
Maris.Logging.Testing.Xunit.XunitLoggerProvider 100% 100%
Microsoft.Extensions.DependencyInjection.TestLoggerServiceCollectionExtensi
ons
100%
Microsoft.Extensions.Logging.FakeLoggingBuilderExtensions 100%
Microsoft.Extensions.Logging.XunitLoggingBuilderExtensions 100%

@tsuna-can-se tsuna-can-se merged commit 93d56f4 into main Mar 12, 2024
7 checks passed
@tsuna-can-se tsuna-can-se deleted the feature/editorconfigの改行コードをLFの対象を全ファイルに変更する branch March 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: ConsoleAppWithDI コンソールアプリケーションの要件別サンプルに関係がある target: Dressca サンプルアプリケーションDresscaに関係がある
Projects
None yet
2 participants