Keep the "library" namespace if it was specified in the image identif…

…ier.

Fixes argoproj-labs#1012.

Signed-off-by: Alessandro Zanatta <[email protected]>

registry-scanner/pkg/image/image.go

@@ -42,7 +42,7 @@ func NewFromIdentifier(identifier string) *ContainerImage {
 		img.ImageAlias = alias
 		img.ImageName = reference.Path(parsed)
 		// if library/ was added to the image name, remove it
-		if !strings.HasPrefix(imgRef, "library/") {
+		if !strings.Contains(imgRef, "library/") {
 			img.ImageName = strings.TrimPrefix(img.ImageName, "library/")
 		}
 		if digested, ok := parsed.(reference.Digested); ok {

registry-scanner/pkg/image/image_test.go

@@ -120,6 +120,18 @@ func Test_ParseImageTags(t *testing.T) {
 		assert.Equal(t, "classic-web", image.ImageName)
 		assert.Nil(t, image.ImageTag)
 	})
+	t.Run("#1012 Parse docker.io image and keep library if present", func(t *testing.T) {
+		image := NewFromIdentifier("docker.io/library/postgres")
+		assert.Equal(t, "docker.io", image.RegistryURL)
+		assert.Equal(t, "library/postgres", image.ImageName)
+		assert.Nil(t, image.ImageTag)
+	})
+	t.Run("#1012 Parse docker.io image and do not keep library if absent", func(t *testing.T) {
+		image := NewFromIdentifier("docker.io/postgres")
+		assert.Equal(t, "docker.io", image.RegistryURL)
+		assert.Equal(t, "postgres", image.ImageName)
+		assert.Nil(t, image.ImageTag)
+	})
 }
 
 func Test_ImageToString(t *testing.T) {