Merge pull request irihitech#496 from irihitech/time

Fix various nullable issue.
Alex6djForkedRepos · Nov 29, 2024 · c2974a5 · c2974a5
2 parents f359f73 + 0acc9c9
commit c2974a5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/src/Ursa/Controls/DateTimePicker/DateTimePicker.cs b/src/Ursa/Controls/DateTimePicker/DateTimePicker.cs
@@ -140,7 +140,7 @@ private void OnDateSelected(object? sender, CalendarDayButtonEventArgs e)
         }
     }
 
-    private void OnTimeSelectedChanged(object sender, TimeChangedEventArgs e)
+    private void OnTimeSelectedChanged(object? sender, TimeChangedEventArgs e)
     {
         if (SelectedDate is null)
         {

diff --git a/src/Ursa/Controls/DateTimePicker/TimePicker.cs b/src/Ursa/Controls/DateTimePicker/TimePicker.cs
@@ -93,7 +93,7 @@ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
         SyncTimeToText(SelectedTime);
     }
 
-    private void OnPresenterTimeChanged(object sender, TimeChangedEventArgs e)
+    private void OnPresenterTimeChanged(object? sender, TimeChangedEventArgs e)
     {
         if (_suppressTextPresenterEvent) return;
         SetCurrentValue(SelectedTimeProperty, e.NewTime);

diff --git a/src/Ursa/Controls/DateTimePicker/TimeRangePicker.cs b/src/Ursa/Controls/DateTimePicker/TimeRangePicker.cs
@@ -156,7 +156,7 @@ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
         SyncTimeToText(EndTime, false);
     }
 
-    private void OnPresenterTimeChanged(object sender, TimeChangedEventArgs e)
+    private void OnPresenterTimeChanged(object? sender, TimeChangedEventArgs e)
     {
         if (_suppressTextPresenterEvent) return;
         SetCurrentValue(Equals(sender, _startPresenter) ? StartTimeProperty : EndTimeProperty, e.NewTime);

diff --git a/tests/HeadlessTest.Ursa/Controls/FormTests/Dynamic_Item_Generation/Test.cs b/tests/HeadlessTest.Ursa/Controls/FormTests/Dynamic_Item_Generation/Test.cs
@@ -26,6 +26,7 @@ public void FormItem_Generation()
         window.Show();
 
         var form = window.FindControl<Form>("Form");
+        Assert.NotNull(form);
         var logicalChildren = form.GetLogicalChildren().ToList();
         Assert.True(logicalChildren.All(a=>a is FormItem));
         Assert.IsType<TextBox>(logicalChildren[0].LogicalChildren[0]);
@@ -65,6 +66,7 @@ public void FormGroup_Generation()
         window.Show();
 
         var form = window.FindControl<Form>("Form");
+        Assert.NotNull(form);
         var logicalChildren = form.GetLogicalChildren().ToList();
         Assert.True(logicalChildren.All(a=>a is FormGroup));
         var formGroup = (FormGroup)logicalChildren[0];
@@ -108,6 +110,7 @@ public void Mixture_Generation()
         window.Show();
 
         var form = window.FindControl<Form>("Form");
+        Assert.NotNull(form);
         var logicalChildren = form.GetLogicalChildren().ToList();
         Assert.True(logicalChildren.All(a=>a is FormItem || a is FormGroup));
         Assert.IsType<TextBox>(logicalChildren[0].LogicalChildren[0]);