NestJS rewrite #49
Merged
NestJS rewrite #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er can return a hardcoded film id
…ta is returned correctly.
…he project e.g. getting an image paths full url to render it correctly in the ui.
… the existing functionality up to make everything consistent.
…ormatting for movies and tv shows
…entService for later use.
…nment service to take into account the entertainment type e.g. movie or tv
… attempts to get other types of clips when the previous type wasn't available
…ity and fixed an issue where some social links weren't always available or empty.
…its in the correct format
…isodeCount. Also improved how gender values are mapped to support all genders available.
…MovieDatabase thrid party token
…tering formData, it's no now offloaded to the BE.
…ainable, along with the structure change theres README files to document the folders.
… more documentation and fixed a bugs noticed whilst creating the unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR the following has been completed:
Rewrote the entire project in NestJS
Reworked the structure of the project to make it easier to identify key areas. With each new section there are various README files which discuss the section.
Added various unit tests with Vitest to cover all the pieces of functionality with the help of Cursor
The project is now type safe, all response interfaces are generated from the Graphql schema. Every other interface is manually maintained as the data is from The Open Movie Database's systems OR the desired types couldn't be automated.
Any environment variables required are now validated via Joi (Would have used zod but couldn't OR you have to do a lot of work just to get it to work)
Updated the github actions to use yarn latest version.
Added a "Discover" module to allow users to quickly search for shows or movies, for now this just mimics what the The Open Movie Database discover page is doing. There still some work that needs doing about this, currently it fetches one one page at a time to get this working at the UI layer it'll need to use an infinite query