Fixed issue with light red theme and updated documentation for alt themes #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2024 22:13
…t themes instead of standard themes
…dard and alt themes
Alexhuszagh
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue with the theme "light-red.json" where the textbox background color matched the alternative themes instead of the other standard themes.
Also updated the documentation to show some other differences between the standard light themes and the alternative light themes.
Removed reference to my fork of this repo as my main changes (PySide and PyQt6) have been merged and so the main repo now matches my fork.
Looks like the CI/CD pipeline is failing at the linter stage due to an apparent issue with "shared.py". Not sure why as I haven't modified it and it looks good. Seems PyLint is being weird, or I'm missing something.