Add dummy feature for nrow=1 altExps #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
Here I am adding a check for altExps with only a single feature when converting to a Seurat v5 assay. If there is only one feature, I add second one named
null-feature
(suggest other names if you have a better idea!) with all zero counts and allNA
rowData.In testing (including a number of added tests), this seems to solve the issue we were having.
(I am assuming that there are not going to be full SCEs with only one feature, or something much bigger is wrong and I am happy to have the function fail.)