-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
392 - Rename context states for DatasetManagerContext #434
Open
nozomione
wants to merge
13
commits into
dev
Choose a base branch
from
nozomione/392-rename-context-states-in-dataset-manager-context
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
392 - Rename context states for DatasetManagerContext #434
nozomione
wants to merge
13
commits into
dev
from
nozomione/392-rename-context-states-in-dataset-manager-context
+130
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in RefinebioContext (during the initial load of the application - replacing the useToken hook) ,and adjusted the other hooks that utilize token
…er viist without activation if it doesn't exist) and use the side effect to sync the token state with acceptedTerms in RefinebioContext, remove the token generation logic from consumer hooks, rename the prop name 'params' to 'body' in interface s methods
…of use checkbox visibility)
… the usage of token/applyAcceptedTerms), and use the token state in hooks instesd (added a new hook useTriggerSubmit - decuple the useEffect until adding conetxt/hook for file download and download options etc)
… accordingly, use this new hook in RefeinbioContext provider and add waitForToken method, use waitForToken in useDatasetManager
… to 'endpoint' for clarity, (minor) remove obsolete interfaces from the api folder
…set/setDataset to myDataset/setMyDataset and from datasetId/setDatasetId to myDatasetId/setMyDatasetID, and adjust the codebase accordingly
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Base automatically changed from
nozomione/413-update-token-validation-flow
to
dev
January 8, 2025 22:19
…taset-manager-context
…t-manager-context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #392
Base branch: PR #421
Purpose/Implementation Notes
I've updated the
DatasetManagerContext
state names,dataset
/setDataset
tomyDataset
/setMyDataset
anddatasetId
/setDatasetId
tomyDatasetId
/setMyDatasetId
, and adjusted the codebase accordingly.Types of changes
Functional tests
N/A
Checklist
Screenshots
N/A