-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous fixes #126
Miscellaneous fixes #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some misgivings about this! If I am going to set up a separate account, the things I don't want to do are install 1Password or login to my personal GitHub account.
* [ ] Setup a non-personal trainer account (e.g., called "Data Lab") on your computer, if this doesn't already exist | ||
* [ ] Ensure the following softwares are installed and working in your trainer account: | ||
* [ ] 1Password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are installing 1Password, I hesitate to call this a non-personal account. Having 1Password set up means that it will have access to ~ everything.
So I'm not actually sure we need a separate account at all? Or if we do, perhaps we should have a "dummy" github account that we use with it and not set up 1Password.
* [ ] Setup a non-personal trainer account (e.g., called "Data Lab") on your computer, if this doesn't already exist | |
* [ ] Ensure the following softwares are installed and working in your trainer account: | |
* [ ] 1Password | |
* [ ] Setup a training account (e.g., called "Data Lab") on your computer, if this doesn't already exist | |
* [ ] Ensure the following softwares are installed and working in your training account: | |
* [ ] 1Password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something that will help a bit is that "non-personal" is absolutely typo and should have said personal, non-work!
The separate account helps me with desktop clutter and definitely.definitely getting notifications off, b/c I'm paranoid, but I don't think it's totally necessary! I can change this to just say make sure you have these things installed, and if you are into it, make a separate non-work account for training only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Joshua Shapiro <[email protected]>
Closes #124
This PR does the small TODOs I identified in #124. Mostly, did I miss anything in instructor setup?