Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup instructions #162

Merged
merged 10 commits into from
May 3, 2024
Merged

Conversation

sjspielman
Copy link
Member

Closes #155

This PR updates setup instructions for OpenRRP. I've commented out the previous setup instructions, and replaced them with instructions containing OpenScPCA links. I'm opening this a draft PR because WSL 2 instructions aren't yet live (so many links are empty for the time being), but this can still be reviewed for content in the meantime.

@sjspielman sjspielman requested a review from jashapiro May 2, 2024 14:09
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we should probably have something here about AWS setup as well. Or at least a placeholder for it?

docs/setup_instructions/setup_overview.md Outdated Show resolved Hide resolved
@sjspielman
Copy link
Member Author

sjspielman commented May 2, 2024

This looks good, but we should probably have something here about AWS setup as well. Or at least a placeholder for it?

Can you clarify this a little bit? I'm not thinking of what AWS setup steps they'd have to do* before coming to the workshop. AWS CLI will get set up after conda, and we're doing LSfR with them.

@jashapiro
Copy link
Member

This looks good, but we should probably have something here about AWS setup as well. Or at least a placeholder for it?

Can you clarify this a little bit? I'm not thinking of what AWS setup steps they'd have to do* before coming to the workshop. AWS CLI will get set up after conda, and we're doing LSfR with them.

I'm assuming there will be some steps to do to login to their account and set up 2FA. These should be outlined in the email they will get, but having a reminder here won't hurt.

@sjspielman sjspielman marked this pull request as ready for review May 3, 2024 13:58
@sjspielman sjspielman requested a review from jashapiro May 3, 2024 14:00
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjspielman sjspielman merged commit ae726ec into main May 3, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/155-setup-instructions branch May 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenRRP: Update installation instructions
2 participants