-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spellcheck the repo #167
Spellcheck the repo #167
Conversation
This is now ready for review. As part of review, please weigh in on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd probably just check all files to keep things simpler. I suggested another way to exclude files from checks if we want to do that.
Othere than that, just a few minor comments.
.github/workflows/spellcheck.yml
Outdated
@@ -28,7 +28,7 @@ jobs: | |||
id: spell | |||
with: | |||
dictionary: components/dictionary.txt | |||
files: "docs/* docs/*/*" | |||
files: "docs/* docs/*/* workshop_materials/cheatsheets/* instructor_notes/* instructor_notes/openscpca/* " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably just remove this at this point and check everything. I'm not too worried about the partial words added being a problem.
I also thought of another thing we could if we want to exclude particular files: add a step with rm
for the files we want the spellchecker to skip.
Co-authored-by: Joshua Shapiro <[email protected]>
Co-authored-by: Joshua Shapiro <[email protected]>
Closes #164
Spellchecking the repo! Filing as a draft to first catch and fix the spelling errors.