Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep docs for release of portal wide metadata #320

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

allyhawkins
Copy link
Member

Closes #318

Here I uncommented out the section of the docs that described the portal wide metadata and added a changelog entry. I kept the changelog entry pretty brief, but let me know if I should expand any more there?

Before we actually release these docs we will need to add a date to the changelog.

@allyhawkins allyhawkins requested a review from sjspielman July 8, 2024 14:09
Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! I mostly suggested emphasizing that it's a TSV.

docs/CHANGELOG.md Outdated Show resolved Hide resolved
@@ -162,9 +162,9 @@ This file will contain fields equivalent to those found in the `single_cell_meta
Metadata for all samples on the Portal is available to download separately from gene expression data downloads.
Each project page has an option to download metadata for all of its samples as a single zip file containing the `metadata.tsv` file and a `README.md` file.
Project-specific metadata will contain all columns listed in [the above table](#metadata) and any additional project-specific columns, such as treatment or outcome.
<!--

Additionally, the metadata for all samples on the Portal is available and contains the metadata for all samples available on the Portal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Additionally, the metadata for all samples on the Portal is available and contains the metadata for all samples available on the Portal.
Additionally, the metadata for all samples on the Portal is available for download as a TSV file and contains the metadata for all samples available on the Portal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof this sentence was a lot of repetition, so I reworded it in c61a0a0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, c61a0a0 is better!

@allyhawkins allyhawkins merged commit 5e616b7 into development Jul 8, 2024
2 checks passed
@allyhawkins allyhawkins deleted the allyhawkins/portal-wide-metadata branch July 8, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants