Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge cell count and fusion nomenclature-related changes to main #361

Merged
merged 12 commits into from
Oct 14, 2024
Merged

Merge cell count and fusion nomenclature-related changes to main #361

merged 12 commits into from
Oct 14, 2024

Conversation

jaclyn-taroni
Copy link
Member

@jaclyn-taroni jaclyn-taroni commented Oct 8, 2024 •
edited
Loading

Purpose

  • Removing sample_cell_count_estimate from description of metdata
  • Adding a description of demux_sample_cell_estimate to multiplexed downloadable files section
  • Adding a CHANGELOG entry that covers the above + the standardization of fusion nomenclature

Issue addressed

#357

Checklist for publishing to main

  • This branch contains all commits/content ready to be released.
  • The most recent CHANGELOG entry includes a date.
    If this release required a CHANGELOG entry, it should be today's date.

jaclyn-taroni and others added 11 commits September 24, 2024 17:46
@jaclyn-taroni
Merge pull request #352 from AlexsLemonade/main
bd4ba32 
Backport Changelog update to `development`
@jaclyn-taroni
Merge pull request #358 from AlexsLemonade/main
fc9deb0
@jaclyn-taroni
Remove sample_cell_count_estimate from metadata table
32e6dc5
@jaclyn-taroni
Add demux_sample_cell_estimate description
138bd93
@jaclyn-taroni
Add CHANGELOG entry for cell count-related changes and fusion update
1939a02
@jaclyn-taroni
Update docs/download_files.md
d8ce523
@jaclyn-taroni
Merge branch 'jaclyn-taroni/354-355-cell-count' into jaclyn-taroni/35…
de6e117 
…6-changelog
@jaclyn-taroni @jashapiro
Apply suggestions from code review
68b284c 
Co-authored-by: Joshua Shapiro <[email protected]>
@jaclyn-taroni
Merge pull request #360 from AlexsLemonade/jaclyn-taroni/356-changelog
119aed1 
Add CHANGELOG entry for cell count-related changes and fusion update
@jaclyn-taroni
Add author last name to dictionary
8b581ea
@jaclyn-taroni
Merge pull request #359 from AlexsLemonade/jaclyn-taroni/354-355-cell…
85075b9 
…-count

Update cell count-related fields description
@jaclyn-taroni jaclyn-taroni marked this pull request as ready for review October 14, 2024 21:05
jaclyn-taroni
jaclyn-taroni commented Oct 14, 2024
View reviewed changes
docs/CHANGELOG.md Outdated Show resolved Hide resolved
davidsmejia
davidsmejia approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaclyn-taroni jaclyn-taroni merged commit ca0162a into main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaclyn-taroni @davidsmejia