Remove title from cell metadata and move schema to object metadata #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashapiro
approved these changes
Oct 2, 2023
bin/sce_to_anndata.R
Outdated
Comment on lines
87
to
89
| # add schema version | ||
| metadata(sce)$schema_version = "3.0.0" | ||
|
|
There was a problem hiding this comment.
I'd move this up to the top of the function. That will hopefully remind us to update both the commend and the metadata element at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on the docs for AnnData contents, I noticed that we accidentally added the
titleand theschema_versionto the cell metadata and not the object metadata. They both should be inmetadata(sce)before converting to AnnData so they get saved inunsin the AnnData object. (see https://github.com/chanzuckerberg/single-cell-curation/blob/main/schema/3.0.0/schema.md#uns-dataset-metadata)I moved the
schema_version, but I didn't really like the idea of making a duplicate of the project ID and saving it totitle. It seems silly and hard to explain in the docs. So because we already haveproject_idsaved in the metadata, I'm leaving that as is and then removing title for now. As with thedonor_idchange if we submit to CZI we will need to add an actualtitlelater anyways.