Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add celltyping to external instructions #502
Add celltyping to external instructions #502
Changes from 30 commits
4d8c4b3
2407746
1f2a543
c414d94
3228b4f
390d6cc
10a510a
6298807
3b2aff9
d7d7ea1
69de0f2
638c761
92a9927
6c9f182
2467ef7
fb42f6f
2cf5384
1072ec9
ffdc7b8
057df40
920e6ae
2326a58
24df4d9
84802a6
856ba33
7361ab9
f6ec451
3acec7f
209b6e5
5e8aafd
fd26234
95e5d17
891a1e5
55627ba
38dba37
94ac08a
83bec1a
49e210a
ffa8edf
447f0c9
2df686b
e8b857d
864a1df
4246e78
df95988
8c9c99b
f946280
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the directory, we also have a sample metadata file and multiplex pools file. So we probably want to note all of these. And maybe we want to give the file names themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you accidentally marked this as resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, no I intentionally resolved it... but for some reason my brain read your comment and, naturally, made this change (and similar) instead 😱
scpca-nf/external-instructions.md
Lines 150 to 151 in 2df686b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not mad about the changes I made, but they are just not at all what your comment was....