Skip to content

Commit

Permalink
Remove testing definition, and actually add the merged altExp into th…
Browse files Browse the repository at this point in the history
…e merged sce
  • Loading branch information
sjspielman committed Dec 11, 2023
1 parent 5553543 commit 66eff6b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
13 changes: 8 additions & 5 deletions R/merge_sce_list.R
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ merge_sce_list <- function(
purrr::reduce(union)

for (altexp_name in altexp_names) {
altexp_name <- "CITEseq"
# Determine which SCEs contain this altExp, and create list of those altExps
has_altexp_name <- sce_list |>
purrr::map_lgl(
Expand Down Expand Up @@ -219,15 +218,19 @@ merge_sce_list <- function(
# Replace existing metadata list with merged metadata
metadata(merged_sce) <- metadata_list


# Add the merged altE into the main merged_sce
if (include_altexp) {
# Apply column names

# Ensure compatible column names
# (this is probably not necessary but doesn't hurt...)
merged_sce <- merged_sce[,merged_colnames]

## TODO: ADD THE `merged_altexps` INTO `merged_sce`
# Add the merged altexps into the merged sce
for (altexp_name in names(merged_altexps)) {
altExp(merged_sce, altexp_name) <- merged_altexps[[altexp_name]]
}
}


return(merged_sce)
}

Expand Down
6 changes: 3 additions & 3 deletions man/create_merged_altexps.Rd → man/create_merged_altexp.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 66eff6b

Please sign in to comment.