Add precommit and specify Seurat version #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update wordlist
allyhawkins
approved these changes
Nov 22, 2023
Co-authored-by: Ally Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238
Here I added precommit to do automatic formatting and linting.
I made the linting a bit more lenient for things we probably don't care much about. The one thing that we were violating but I left was
cyclocomp_linter, which tries to prevent too much complexity in functions. But we only violated that in one place, so I just used# nolintflags to disable it in that one place.I also did an initial run at #239 in the most simple way I could, just setting that
Seurathas to be < v5.0.0.