Use AddMetaData #241
Merged
Use AddMetaData #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyhawkins
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239
This ended up a pretty small fix: I used the
AddMetaDataSeurat function rather than adding directly to the slot. I think we actually were adding the wrong slot anyway: we had been usingvar.features, whereas I think the correct slot wasmeta.featuresall along. Which can be accessed with justobject[[assay]][[]]as I do in the tests now.I think I could have used
object[[assay]][[]] <- rowdata, but this seemed safer.I tested with both Seurat 4.4 and 5.0, and both seemed to work on my machine.