-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to merge altExps #243
Merged
Merged
Changes from 26 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
04bdfcd
add comment for future us that this merge script is not about _mergin…
sjspielman b9b7625
lay the groundwork for new include_altexp argument, currently set to …
sjspielman abaa73c
implement functions for updating altExp with NA features where needed
sjspielman 0e9e1c4
Update some variable names and comments, ensure altExp is prepared fo…
sjspielman a33229d
fix typo
sjspielman 76d5ec2
lay some groundwork for forthcoming altexp merging tests, but no test…
sjspielman cf0cf82
For now, turn off altexp merging in the tests to get them passing
sjspielman 382da05
clean up a comment
sjspielman 4a44d65
batch ->sce_name argument
sjspielman ed2cb9a
no need to re data.frame this, since we're not adding rownames here
sjspielman 5a60129
one more test spot to turn off altexps for now
sjspielman 73cc8b4
Apply suggestions from code review
sjspielman bd21cec
One purrr syntax bump, and changes in response to review: update new …
sjspielman bfa6846
WIP towards updated altexps strategy
sjspielman 8149ed6
Revert "WIP towards updated altexps strategy"
sjspielman 3d70229
Fundamental merge altExp code overhaul: Build an empty matrix first a…
sjspielman c0e9da5
rename function merged_altexps -> create_merged_altexps to avoid over…
sjspielman f63c268
but make it singular
sjspielman 5553543
run devtools::document
sjspielman 66eff6b
Remove testing definition, and actually add the merged altExp into th…
sjspielman 4689d94
Apply suggestions from code review
sjspielman bdaa9cc
Apply suggestions from code review
sjspielman 87c7647
merged_colnames -> all_merged_barcodes
sjspielman 5220754
union and comment
sjspielman 4506626
respond to variable naming reviews and add missing pipe
sjspielman 288d61b
run document
sjspielman 4eea2bf
use regular map to avoid failures if there are no altexps; behavior e…
sjspielman 6090faf
Use an actual number, no altexps in sce_list, and remove all include_…
sjspielman 921b0bc
Update test names, no altexps. Add some comment structure for navigat…
sjspielman 70655dc
Add a test for merging with altexps
sjspielman bc23a88
a bit of code rearrangement
sjspielman 265f3a8
add test for include_altexp=FALSE when altexps are present
sjspielman c6afdeb
Apply suggestions from code review
sjspielman ce257ef
Update tests in response to review
sjspielman b16805d
Update tests/testthat/test-merge_sce_list.R
sjspielman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯