Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to R 4.4 & renv 3.19 #273

Merged
merged 14 commits into from
May 3, 2024
Merged

Update to R 4.4 & renv 3.19 #273

merged 14 commits into from
May 3, 2024

Conversation

jashapiro
Copy link
Member

@jashapiro jashapiro commented May 3, 2024

This PR updates scpcaTools development environment and docker to use R 4.4 and Bioconductor 3.19.

When running checks, I found a couple of missing escape characters in documentation, so I added those as well. All checks passed locally, so hopefully there are not any breaking changes!

closes #272

@jashapiro jashapiro requested a review from allyhawkins May 3, 2024 12:42
@jashapiro
Copy link
Member Author

Looks like I forgot to update the sub-lockfiles, which is probably why the 1st docker build attempt failed.

When testing this though, I wanted to try building straight from the scpcaTools version in the PR, rather than what gets pulled from github, so I moved the dockerfile up a level, and rearranged a few things to make sure everything kept working as expected.

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jashapiro jashapiro merged commit aba6322 into main May 3, 2024
7 checks passed
@jashapiro jashapiro deleted the jashapiro/bioc3.19 branch May 3, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update renv and docker to R 4.4 and Bioconductor 3.19
2 participants