Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set seeds conditionally #281

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Set seeds conditionally #281

merged 7 commits into from
Sep 5, 2024

Conversation

jashapiro
Copy link
Member

closes #280

Here I modified seed setting to only happen if the seed is not NULL across all files.

Some of the modified files failed linting, so I made a few updates related to that as well, including making the linter a bit more tolerant of complex code.

The styler also got a bit hung up on some code; turns out it doesn't like extra space in example code, but that took a very long time to find!

@jashapiro jashapiro requested a review from sjspielman September 4, 2024 21:32
Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! good catch here.

@jashapiro jashapiro merged commit 0b5d4ac into main Sep 5, 2024
7 checks passed
@jashapiro jashapiro deleted the jashapiro/280-null-seed-fix branch September 5, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Resetting seeds with NULL
2 participants